feat(region): Add threshold for drawing region#614
Merged
mergify[bot] merged 5 commits intobox:masterfrom Oct 6, 2020
Merged
Conversation
mingzexiao6
force-pushed
the
add-threshold
branch
from
1a7b2b3 to
9d8057b
Compare
ConradJChan
reviewed
Oct 5, 2020
mingzexiao6
force-pushed
the
add-threshold
branch
from
cb1a9e6 to
5972586
Compare
ConradJChan
reviewed
Oct 5, 2020
ConradJChan
reviewed
Oct 5, 2020
mingzexiao6
force-pushed
the
add-threshold
branch
from
3cb86cd to
62989b8
Compare
jstoffan
reviewed
Oct 5, 2020
jstoffan
reviewed
Oct 6, 2020
| document.removeEventListener('mouseup', handleMouseUp); | ||
| }; | ||
| }, [isDrawing]); // eslint-disable-line react-hooks/exhaustive-deps | ||
| }, [drawingStatus]); // eslint-disable-line react-hooks/exhaustive-deps |
Collaborator
There was a problem hiding this comment.
The major downside here is that we will destroy/recreate the render loop and also remove/re-add the handlers when the status changes from dragging to drawing. Should we only cleanup when in init status? Will that lead to bugs or hanging references?
Contributor
Author
There was a problem hiding this comment.
I tried to add listeners at the beginning of dragging and don't remove them at the end of dragging but remove them at the end of drawing. Unfortunately it doesn't work. The reason is that every render creates a new handleMouseUp function instance. The cleanup callback of drawing cannot remove the listener created in dragging. We can memo all the functions but I think it's better to do in another PR.
jstoffan
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: