test(cypress): Add E2E tests for promoting highlight annotations#623
Merged
mergify[bot] merged 2 commits intobox:masterfrom Oct 9, 2020
Merged
test(cypress): Add E2E tests for promoting highlight annotations#623mergify[bot] merged 2 commits intobox:masterfrom
mergify[bot] merged 2 commits intobox:masterfrom
Conversation
jstoffan
previously approved these changes
Oct 9, 2020
ConradJChan
reviewed
Oct 9, 2020
| cy.getByTestId('ba-Layer--highlight'); | ||
|
|
||
| // Assert that only one highlight annotation created in the above test is present | ||
| cy.get('.ba-HighlightTarget').should('have.length', 1); |
Contributor
There was a problem hiding this comment.
Can cypress tests be run individually? Seems like we should try to avoid relying on side effects of other tests if possible
Collaborator
There was a problem hiding this comment.
We would need to manually delete any existing annotations in a teardown step after each test and/or suite.
Contributor
There was a problem hiding this comment.
That or we could go back to that logic @mxiao6 had to count the annotations before and after so it's more of a relative check?
Contributor
Author
There was a problem hiding this comment.
How about combining them into one test?
mingzexiao6
force-pushed
the
test-highlight-promotion
branch
from
ce1b300 to
8f779f2
Compare
ConradJChan
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.