Skip to content

fix(tests): BaseAnnotator test emitter leak#628

Merged
ConradJChan merged 2 commits intobox:masterfrom
ConradJChan:fix-emitter-leak
Oct 21, 2020
Merged

fix(tests): BaseAnnotator test emitter leak#628
ConradJChan merged 2 commits intobox:masterfrom
ConradJChan:fix-emitter-leak

Conversation

@ConradJChan
Copy link
Contributor

Clean up the existing annotator before getting a new one.

This cleans up the following when running tests:

(node:6655) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 scaleannotations listeners added to [EventManager]. Use emitter.setMaxListeners() to increase limit
(node:6655) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 annotations_active_set listeners added to [EventManager]. Use emitter.setMaxListeners() to increase limit
(node:6655) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 annotations_remove listeners added to [EventManager]. Use emitter.setMaxListeners() to increase limit
(node:6655) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 annotations_visible_set listeners added to [EventManager]. Use emitter.setMaxListeners() to increase limit

@ConradJChan ConradJChan requested a review from a team as a code owner October 21, 2020 21:47
jstoffan
jstoffan previously approved these changes Oct 21, 2020
@ConradJChan ConradJChan merged commit db5e289 into box:master Oct 21, 2020
@ConradJChan ConradJChan deleted the fix-emitter-leak branch October 21, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants