Fix: Invalidate draw/highlight annotations without properly structured locations#9
Merged
pramodsum merged 6 commits intobox:masterfrom Oct 30, 2017
pramodsum:draw
Merged
Fix: Invalidate draw/highlight annotations without properly structured locations#9pramodsum merged 6 commits intobox:masterfrom pramodsum:draw
pramodsum merged 6 commits intobox:masterfrom
pramodsum:draw
Conversation
pramodsum
changed the title
jeremypress
approved these changes
Oct 27, 2017
| * | ||
| * @param {Object} location Highlight annotation thread location object | ||
| * @return {boolean} Whether or not the highlight annotation has the correct location information | ||
| */ |
There was a problem hiding this comment.
isValidHighlightLocation and isValidDrawLocation?
added 2 commits
October 27, 2017 16:01
- A temp draw thread is created without a valid location in order to set up the thread handlers in DrawingModeController. This changes the method to directly create a new DocDrawingThread without validating location. - Cleaning up validation methods
| @@ -488,6 +508,12 @@ export function isPending(threadState) { | |||
| */ | |||
| export function validateThreadParams(thread) { | |||
Contributor
There was a problem hiding this comment.
same as above. areValidThreadParams()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.