Remove client ID and secret from connection state #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the client ID and client secret parameters from the JSON state blob for BoxAPIConnections. It generally isn't a good security practice to store your client ID and secret along with access/refresh tokens, so the restore method was changed to take them as separate parameters which need to be provided by the application. There is also a new non-static `restore(String)` method that allows for a connection state to be restored into an existing connection. This method helps in situations where the saved state isn't immediately available when the API connection is constructed.
|
Verified that @gcurtis has signed the CLA. Thanks for the pull request! |
Contributor
Author
|
@tluthra - let me know if it looks like this will work for you guys. |
gcurtis
added a commit
that referenced
this pull request
Apr 15, 2015
Remove client ID and secret from connection state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the client ID and client secret parameters from the
JSON state blob for BoxAPIConnections. It generally isn't a good
security practice to store your client ID and secret along with
access/refresh tokens, so the restore method was changed to take them as
separate parameters which need to be provided by the application.
There is also a new non-static
restore(String)method that allows fora connection state to be restored into an existing connection. This
method helps in situations where the saved state isn't immediately
available when the API connection is constructed.