Watermarking features#342
Merged
dmaynard merged 2 commits intobox:masterfrom Nov 30, 2016
Merged
Conversation
|
Verified that @gleb-urvanov has signed the CLA. Thanks for the pull request! |
gleb-urvanov
changed the title
gleb-urvanov
force-pushed
the
feature/watermark
branch
4 times, most recently
from
7ca3228 to
a4ac560
Compare
gleb-urvanov
force-pushed
the
feature/watermark
branch
from
a4ac560 to
7fd5681
Compare
dmaynard
reviewed
Nov 17, 2016
| this.removeWatermark(FILE_URL_TEMPLATE); | ||
| } | ||
|
|
||
| private String scopeBasedOnType(String typeName) { |
Contributor
There was a problem hiding this comment.
Please remove this method. BoxFile has been refactored since you created this branch. and this method has been moved to the MetaData class.
dmaynard
reviewed
Nov 17, 2016
Contributor
dmaynard
left a comment
dmaynard
left a comment
There was a problem hiding this comment.
Looks good. One comment to remove the scopeBasedOnType method from the BoxFile Class as this has been refactored into the MetaData Class.
Thank you.
gleb-urvanov
force-pushed
the
feature/watermark
branch
3 times, most recently
from
e81f827 to
8be668b
Compare
gleb-urvanov
force-pushed
the
feature/watermark
branch
from
8be668b to
4e6ed92
Compare
Contributor
Author
|
Thank you for the review! Excess method was removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watermarking features implemented for BoxFile and BoxFolder with unit tests and markdown documentation.