Conversation
|
Verified that @dmaynard has signed the CLA. Thanks for the pull request! |
gcurtis
suggested changes
Nov 17, 2016
Contributor
gcurtis
left a comment
gcurtis
left a comment
There was a problem hiding this comment.
Just a minor fix is needed with the isWatermarked field.
| * Gets flag indicating whether this file is Watermarked. | ||
| * @return whether the file is watermarked or not | ||
| */ | ||
| public Boolean getIsWatermarked() { |
Contributor
There was a problem hiding this comment.
This should be lowercase boolean.
| private BoxFolder.Info parent; | ||
| private String itemStatus; | ||
| private Set<BoxCollection.Info> collections; | ||
| private Boolean isWatermarked; |
Contributor
There was a problem hiding this comment.
Lowercase boolean to use the primitive datatype.
gcurtis
suggested changes
Nov 18, 2016
| * Gets flag indicating whether this file is Watermarked. | ||
| * @return whether the file is watermarked or not | ||
| */ | ||
| public Boolean getIsWatermarked() { |
Contributor
There was a problem hiding this comment.
This also needs to be lowercase boolean.
| * Gets flag indicating whether this file is Watermarked. | ||
| * @return whether the file is watermarked or not | ||
| */ | ||
| public Boolean getIsWatermarked() { |
Contributor
There was a problem hiding this comment.
This also needs to be lowercase boolean.
Contributor
Author
|
Changed isWatermarked from Boolean to boolean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.