Skip to content

Conversation

@dmaynard
Copy link
Contributor

No description provided.

@boxcla
Copy link

boxcla commented Jan 27, 2017

Verified that @dmaynard has signed the CLA. Thanks for the pull request!

private TestConfig() { }

public static void setLogLevel(String levelString) {
public static Logger setLogLevel(String levelString) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing the name to enableLogger(String)? I think that's a slightly better name for a function that actually returns a logger.

@Test
@Category(IntegrationTest.class)
public void receiveEventsForFolderCreateAndFolderDelete() throws InterruptedException {
// Logger logger = TestConfig.setLogLevel("FINE");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this.

@gcurtis gcurtis merged commit 3be6d5f into master Feb 13, 2017
@gcurtis gcurtis deleted the enableTestLogging branch February 13, 2017 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants