Skip to content

Deprecated enums still being used #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mittal-umang wants to merge 2 commits into from
Closed

Deprecated enums still being used #932

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
325b45e
Deprecated enums still being used #931
mittal-umang Oct 27, 2021
d84e474
Deprecated enums still being used #931
mittal-umang Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/main/java/com/box/sdk/EventLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ public class EventLog implements Iterable<BoxEvent> {
* @param position the starting position of the event stream.
* @param after the lower bound on the timestamp of the events returned.
* @param before the upper bound on the timestamp of the events returned.
* @param types an optional list of event types to filter by.
* @param eventTypes an optional list of event types to filter by.
* @return a log of all the events that met the given criteria.
*/
public static EventLog getEnterpriseEvents(BoxAPIConnection api, String position, Date after, Date before,
BoxEvent.Type... types) {
return getEnterpriseEvents(api, position, after, before, ENTERPRISE_LIMIT, types);
BoxEvent.EventType... eventTypes) {
return getEnterpriseEvents(api, position, after, before, ENTERPRISE_LIMIT, eventTypes);
}

/**
Expand All @@ -69,11 +69,12 @@ public static EventLog getEnterpriseEvents(BoxAPIConnection api, String position
* @param api the API connection to use.
* @param after the lower bound on the timestamp of the events returned.
* @param before the upper bound on the timestamp of the events returned.
* @param types an optional list of event types to filter by.
* @param eventTypes an optional list of event types to filter by.
* @return a log of all the events that met the given criteria.
*/
public static EventLog getEnterpriseEvents(BoxAPIConnection api, Date after, Date before, BoxEvent.Type... types) {
return getEnterpriseEvents(api, null, after, before, ENTERPRISE_LIMIT, types);
public static EventLog getEnterpriseEvents(BoxAPIConnection api, Date after, Date before,
BoxEvent.EventType... eventTypes) {
return getEnterpriseEvents(api, null, after, before, ENTERPRISE_LIMIT, eventTypes);
}

/**
Expand All @@ -85,15 +86,15 @@ public static EventLog getEnterpriseEvents(BoxAPIConnection api, Date after, Dat
* @param after the lower bound on the timestamp of the events returned.
* @param before the upper bound on the timestamp of the events returned.
* @param limit the number of entries to be returned in the response.
* @param types an optional list of event types to filter by.
* @param eventTypes an optional list of event types to filter by.
* @return a log of all the events that met the given criteria.
*/
public static EventLog getEnterpriseEvents(BoxAPIConnection api, String position, Date after, Date before,
int limit, BoxEvent.Type... types) {
int limit, BoxEvent.EventType... eventTypes) {

URL url = ENTERPRISE_EVENT_URL_TEMPLATE.build(api.getBaseURL());

if (position != null || types.length > 0 || after != null
if (position != null || eventTypes.length > 0 || after != null
|| before != null || limit != ENTERPRISE_LIMIT) {
QueryStringBuilder queryBuilder = new QueryStringBuilder(url.getQuery());

Expand All @@ -115,9 +116,9 @@ public static EventLog getEnterpriseEvents(BoxAPIConnection api, String position
queryBuilder.appendParam("limit", limit);
}

if (types.length > 0) {
if (eventTypes.length > 0) {
StringBuilder filterBuilder = new StringBuilder();
for (BoxEvent.Type filterType : types) {
for (BoxEvent.EventType filterType : eventTypes) {
filterBuilder.append(filterType.name());
filterBuilder.append(',');
}
Expand Down