Long download requests#95
Merged
tluthra merged 1 commit intobox:masterfrom Mar 20, 2015
Merged
Conversation
|
Verified that @tluthra has signed the CLA. Thanks for the pull request! |
Contributor
|
Looks good to me! Just a minor detail - could you put your pull request description in the actual commit message? It does a good job of explaining what this change does and it'd be helpful to have it in the git log. |
…s to listen to the input stream since the disconnect isn't called in the exception scenario. I moved the disconnect in a finally block to make sure that it will be called immediately and not leave the network up and running.
tluthra
force-pushed
the
download-disconnect
branch
from
2cf87f3 to
3ecffda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a download request gets terminated, or errors the request continues to listen to the input stream since the disconnect isn't called in the exception scenario. I moved the disconnect in a finally block to make sure that it will be called immediately and not leave the network up and running.