Skip to content

ts migrate: src/sessions/persistent-session.ts#593

Merged
mhagmajer merged 5 commits intomainfrom
sessions-persistent-session
Apr 29, 2021
Merged

ts migrate: src/sessions/persistent-session.ts#593
mhagmajer merged 5 commits intomainfrom
sessions-persistent-session

Conversation

@mhagmajer
Copy link
Copy Markdown
Contributor

No description provided.

@swfree
Copy link
Copy Markdown
Contributor

swfree commented Apr 28, 2021

Build failures are coming from typescript compilation errors: Property 'unwrapAndThrow' does not exist on type 'typeof import("/home/travis/build/box/box-node-sdk/src/util/errors")' -- https://travis-ci.com/github/box/box-node-sdk/jobs/501826702

Should be fixed if you update this to export = https://github.com/box/box-node-sdk/blob/main/src/util/errors.ts#L76

Comment thread src/sessions/persistent-session.ts Outdated
@mhagmajer
Copy link
Copy Markdown
Contributor Author

Thanks for the review @swfree! I've applied the changes you requested.

@mhagmajer mhagmajer merged commit e04cf13 into main Apr 29, 2021
@mhagmajer mhagmajer deleted the sessions-persistent-session branch April 29, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants