feat(preview): use uploader_display_name for sidebar uploader info#2091
Merged
omgrief merged 2 commits intobox:masterfrom Apr 23, 2020
Merged
feat(preview): use uploader_display_name for sidebar uploader info#2091omgrief merged 2 commits intobox:masterfrom
omgrief merged 2 commits intobox:masterfrom
Conversation
omgrief
force-pushed
the
use-uploader-display-name
branch
from
59bd08f to
49baa4f
Compare
ConradJChan
reviewed
Apr 21, 2020
omgrief
force-pushed
the
use-uploader-display-name
branch
from
49baa4f to
8041c59
Compare
ConradJChan
reviewed
Apr 21, 2020
| uploader={getProp(file, 'created_by.name')} | ||
| // use uploader_display_name if uploaded anonymously | ||
| uploader={ | ||
| getProp(file, 'created_by.id') === 2 |
Contributor
There was a problem hiding this comment.
Is it string '2' or number 2? Could we reference a constant like
box-ui-elements/src/constants.js
Line 382 in 9fd8627
omgrief
force-pushed
the
use-uploader-display-name
branch
from
8041c59 to
c0f3562
Compare
ConradJChan
approved these changes
Apr 23, 2020
alexkrolick
approved these changes
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.