Skip to content

feat(notifications): increase z-index#4473

Merged
mergify[bot] merged 6 commits intobox:masterfrom
jmcbgaston:increase-notification-z-index
Mar 12, 2026
Merged

feat(notifications): increase z-index#4473
mergify[bot] merged 6 commits intobox:masterfrom
jmcbgaston:increase-notification-z-index

Conversation

@jmcbgaston
Copy link
Contributor

@jmcbgaston jmcbgaston commented Mar 9, 2026

Summary

  • Increase notifications-wrapper-z-index from 200 to 400 so notifications render above Blueprint modal (z-index 370).
  • Update SCSS, variables.json, variables.ts, and variables.js for consistency.
  • Re-enable pointer events on the notification container so toasts stay clickable/hoverable when a Radix (Blueprint) modal has disabled pointer events on the rest of the page.

Summary by CodeRabbit

  • Bug Fixes

    • Notifications now reliably appear above other UI elements (including modal overlays) to avoid being obscured.
    • Notification hit-testing improved so clicks and hovers target notifications and their controls instead of underlying elements.
  • Style

    • Minor visual and animation tweaks for smoother rendering, including shadow and transition refinements.

@jmcbgaston jmcbgaston requested review from a team as code owners March 9, 2026 22:33
@CLAassistant
Copy link

CLAassistant commented Mar 9, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a4179038-dd0d-46a2-958b-d6a56b9cca17

📥 Commits

Reviewing files that changed from the base of the PR and between 3667ba2 and 183cc90.

📒 Files selected for processing (5)
  • src/components/notification/Notification.scss
  • src/styles/constants/_layout.scss
  • src/styles/variables.js
  • src/styles/variables.json
  • src/styles/variables.ts
🚧 Files skipped from review as they are similar to previous changes (4)
  • src/styles/variables.js
  • src/styles/variables.json
  • src/components/notification/Notification.scss
  • src/styles/constants/_layout.scss

Walkthrough

The notifications wrapper z-index was increased from 200 to 400 across SCSS, JSON, JS, and TS style files; Notification component SCSS also added pointer-events adjustments and minor formatting fixes.

Changes

Cohort / File(s) Summary
Layout Constants
src/styles/constants/_layout.scss
Bumped $notifications-wrapper-z-index from 200 !default to 400 !default; inline comment references Blueprint modal (370).
Serialized & Runtime Variables
src/styles/variables.json, src/styles/variables.js, src/styles/variables.ts
Updated notifications-wrapper-z-index / notificationsWrapperZIndex values from 200 to 400 in JSON, JS, and TS exports.
Notification Styles
src/components/notification/Notification.scss
Added pointer-events: none to .notifications-wrapper and pointer-events: auto to .notification-container; fixed box-shadow alpha and normalized transition duration formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ready-to-merge

Suggested reviewers

  • tjuanitas
  • jfox-box

Poem

🐰 I hopped up high to tweak the stack,
Four hundred now keeps notices on track,
Pointers pass through, clicks find their way,
Shadows and transitions lined up to play,
A cheerful rabbit's tiny hooray.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(notifications): increase z-index' clearly describes the main change—increasing the z-index of the notifications wrapper—which is the primary objective of this changeset.
Description check ✅ Passed The description provides a clear summary of changes across multiple files, explains the rationale (Blueprint modal compatibility), and mentions the pointer events adjustments, covering the main objectives effectively.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jmcbgaston jmcbgaston force-pushed the increase-notification-z-index branch from d007c2c to 642e177 Compare March 9, 2026 22:37
@jmcbgaston jmcbgaston force-pushed the increase-notification-z-index branch from 642e177 to 3667ba2 Compare March 9, 2026 23:01
@tjuanitas
Copy link
Contributor

FYI we're cautious of changes to the src/styles directory because of how it'll impact existing applications and the interaction with blueprint. it's best to keep the blueprint team informed of the changes cc:@jaknas

* fix(deps): Upgrade draft-js immutable to 3.8.3

* fix: abc

* fix: Update immutable in peer and dev dependencies
@jmcbgaston jmcbgaston force-pushed the increase-notification-z-index branch from c7d3e74 to 98612f8 Compare March 11, 2026 17:48
@mergify mergify bot added the queued label Mar 12, 2026
@mergify mergify bot merged commit dee3185 into box:master Mar 12, 2026
7 of 8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2026

Merge Queue Status

  • Entered queue2026-03-12 16:54 UTC · Rule: Automatic strict merge
  • Checks passed · in-place
  • Merged2026-03-12 16:55 UTC · at 70b3639f9953c656eb7695673deb5049724a8b02

This pull request spent 6 seconds in the queue, with no time running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Summary
    • check-neutral = Summary
    • check-skipped = Summary
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_test_build
    • check-neutral = lint_test_build
    • check-skipped = lint_test_build
  • any of [🛡 GitHub branch protection]:
    • check-success = license/cla
    • check-neutral = license/cla
    • check-skipped = license/cla
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_pull_request
    • check-neutral = lint_pull_request
    • check-skipped = lint_pull_request

@mergify mergify bot removed the queued label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants