fix(activity-feed-v2): use newest version number for multi-version activities#4600
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR updates the version transformation logic in the activity feed to handle missing version numbers more gracefully. ChangesVersion Number Fallback
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge Queue Status
This pull request spent 1 minute 4 seconds in the queue, including 19 seconds running CI. Required conditions to merge
|
Summary
/file_activitiesreturns a singleversionsactivity spanning multiple versions,Feed.jsonly assignsversion_numberifstart === end. For ranges, onlyversion_endandversion_startare populated.transformVersionToPropswas producingversionNumber: 0in that case, causingonVersionHistoryClickto receive 0.version_end(the newest version number in the range) whenversion_numberis unset.Test plan
transformers.test.tsyarn test --watchAll=false --testPathPattern="activity-feed-v2/__tests__/transformers"(62 passed)Summary by CodeRabbit