style(deps): bump activity-feed and threaded-annotations#4619
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR updates several ChangesActivity Feed Component Updates
Possibly related PRs
Suggested labels
Suggested reviewers
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The published @box/activity-feed list now scrolls on its own ul (overflow-y: auto) and applies horizontal padding to its rows. The adapter wrapper was also setting overflow: hidden auto and a &-list > ul > li padding rule, which created a second scroll container and double-applied padding. Use overflow: hidden so the inner ul is the single scroller, and drop the item padding rule.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
b1a68cc to
3ad052b
Compare
Blueprint Text CSS-module hash shifted with the blueprint-web bump.
Merge Queue Status
This pull request spent 12 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
Summary
@box/activity-feedto ^1.23.0 and@box/threaded-annotationsto ^1.96.1, plus their peer Box deps (@box/blueprint-webmajor to ^15.6.0,@box/blueprint-web-assets,@box/collaboration-popover,@box/readable-time,@box/user-selector).ActivityFeedV2.scssthat became redundant once the published list ships its own scroll container and row padding: switch the wrapper fromoverflow: hidden autotooverflow: hiddenso the innerulis the single scroller, and remove the&-list > ul > lipadding override.SidebarFilePropertiessnapshot for the new Blueprint Text CSS-module hash.Test plan
yarn installclean,npx yarn-deduplicate yarn.lockno further changesyarn test --watchAll=false --testPathPattern="activity-feed-v2"-> 192/192 passingyarn test --watchAll=false --testPathPattern="SidebarFileProperties"-> 4/4 passingyarn lint:tscleanSummary by CodeRabbit
Chores
Style