Skip to content

style(deps): bump activity-feed and threaded-annotations#4619

Merged
mergify[bot] merged 4 commits into
box:masterfrom
jackiejou:chore/bump-activity-feed-threaded-annotations-4
Jun 9, 2026
Merged

style(deps): bump activity-feed and threaded-annotations#4619
mergify[bot] merged 4 commits into
box:masterfrom
jackiejou:chore/bump-activity-feed-threaded-annotations-4

Conversation

@jackiejou

@jackiejou jackiejou commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump @box/activity-feed to ^1.23.0 and @box/threaded-annotations to ^1.96.1, plus their peer Box deps (@box/blueprint-web major to ^15.6.0, @box/blueprint-web-assets, @box/collaboration-popover, @box/readable-time, @box/user-selector).
  • Drop two adapter rules in ActivityFeedV2.scss that became redundant once the published list ships its own scroll container and row padding: switch the wrapper from overflow: hidden auto to overflow: hidden so the inner ul is the single scroller, and remove the &-list > ul > li padding override.
  • Refresh the SidebarFileProperties snapshot for the new Blueprint Text CSS-module hash.

Test plan

  • yarn install clean, npx yarn-deduplicate yarn.lock no further changes
  • yarn test --watchAll=false --testPathPattern="activity-feed-v2" -> 192/192 passing
  • yarn test --watchAll=false --testPathPattern="SidebarFileProperties" -> 4/4 passing
  • yarn lint:ts clean
  • Visually verify activity feed scrolls fully to the bottom and rows have correct horizontal padding in the sidebar

Summary by CodeRabbit

  • Chores

    • Updated dependency versions for multiple Box packages across development and peer dependencies.
  • Style

    • Adjusted Activity Feed v2 styling to simplify overflow behavior and improve list layout/spacing.

@jackiejou jackiejou requested review from a team as code owners June 9, 2026 20:12
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e5e5831-58c7-4059-a34a-72979c4cd023

📥 Commits

Reviewing files that changed from the base of the PR and between 3ad052b and c981107.

⛔ Files ignored due to path filters (2)
  • src/elements/content-sidebar/__tests__/__snapshots__/SidebarFileProperties.test.js.snap is excluded by !**/*.snap
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

Walkthrough

This PR updates several @box/* dependency versions in package.json (dev and peer) and adjusts ActivityFeed V2 SCSS: sets wrapper overflow to hidden and removes list-item left/right padding rules.

Changes

Activity Feed Component Updates

Layer / File(s) Summary
Dependency Version Updates
package.json
Updated @box/activity-feed, @box/blueprint-web, @box/blueprint-web-assets, @box/cldr-data, @box/collaboration-popover, @box/readable-time, @box/threaded-annotations, and @box/user-selector versions in both devDependencies and peerDependencies.
ActivityFeed V2 Styling Adjustments
src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss
Changed ActivityFeed V2 wrapper overflow to overflow: hidden and removed the &-list > ul > li left/right padding reset while preserving &-list { display: contents }.

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • jmcbgaston
  • jpan-box
  • jfox-box

🐰 I hopped through diffs with a twitch and a twitchy ear,
bumped versions and smoothed one CSS tear.
Overflow quiet, list spacing gone,
dependencies tuned, the build hums on.
A little rabbit clap — the changes are clear!

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: bumping dependency versions for activity-feed and threaded-annotations packages, which is the primary focus of the PR.
Description check ✅ Passed The PR description includes a comprehensive summary of changes, test plan with passing results, and is well-organized. However, it does not follow the provided template structure, which appears to be about merge process instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jackiejou added 2 commits June 9, 2026 13:13
The published @box/activity-feed list now scrolls on its own ul
(overflow-y: auto) and applies horizontal padding to its rows. The
adapter wrapper was also setting overflow: hidden auto and a
&-list > ul > li padding rule, which created a second scroll
container and double-applied padding.

Use overflow: hidden so the inner ul is the single scroller, and
drop the item padding rule.
@socket-security

socket-security Bot commented Jun 9, 2026

Copy link
Copy Markdown

@jackiejou jackiejou force-pushed the chore/bump-activity-feed-threaded-annotations-4 branch from b1a68cc to 3ad052b Compare June 9, 2026 20:13
Comment thread src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss
@jackiejou jackiejou changed the title chore(deps): bump activity-feed and threaded-annotations style(deps): bump activity-feed and threaded-annotations Jun 9, 2026
Comment thread package.json
@mergify

mergify Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-06-09 23:40 UTC · Rule: Automatic strict merge
  • Checks skipped · PR is already up-to-date
  • Merged2026-06-09 23:40 UTC · at c9811075e5d7bd944398344ef8138cb25b06cd2c · squash

This pull request spent 12 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify mergify Bot merged commit b129717 into box:master Jun 9, 2026
11 of 12 checks passed
@mergify mergify Bot removed the queued label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants