Skip to content

fix: support mid-migration metadata templates #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakubKida wants to merge 14 commits into
base: master
Choose a base branch
from
Open

fix: support mid-migration metadata templates #4653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1c9824d
fix: support mid-migration metadata templates
JakubKida Jul 15, 2026
b80986d
fix(metadata-sidebar): fix mocks
JakubKida Jul 15, 2026
44b6a76
fix(metadata-sidebar): Add dependency
JakubKida Jul 16, 2026
1ce2b45
fix(metadata-sidebar): Add to ignore patterns
JakubKida Jul 16, 2026
a9dca29
feat(metadata-sidebar): Add enterprise id hook ans tests
JakubKida Jul 17, 2026
359b436
fix(metadata-sidebar): Fix flow issues
JakubKida Jul 20, 2026
bd69908
fix(metadata-sidebar): Address improvements
JakubKida Jul 24, 2026
49ea682
feat(metadata-sidebar): Improve mode hook
JakubKida Jul 29, 2026
67606b8
feat(metadata-sidebar): compose hooks
JakubKida Aug 3, 2026
2e80493
feat(metadata-sidebar): Fix naming
JakubKida Aug 3, 2026
137f9c1
feat(metadata-editor): Fix flow types
JakubKida Aug 3, 2026
6427621
feat(metadata-sidebar): Change todos
JakubKida Aug 3, 2026
47c2478
feat(metadata-sidebar): Adress comments
JakubKida Aug 4, 2026
5009754
fix(metadata-sidebar): fix typing failures
JakubKida Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,11 @@
"last 2 Edge versions",
"last 2 iOS versions"
],
"development": ["last 1 Chrome versions", "last 1 Firefox versions", "last 1 Safari versions"]
"development": [
"last 1 Chrome versions",
"last 1 Firefox versions",
"last 1 Safari versions"
]
},
"husky": {
"hooks": {
Expand Down Expand Up @@ -138,10 +142,11 @@
"@box/frontend": "^11.0.1",
"@box/item-icon": "^3.2.0",
"@box/languages": "^1.0.0",
"@box/metadata-editor": "^2.2.28",
"@box/metadata-editor": "^2.3.0",
"@box/metadata-filter": "^1.80.23",
"@box/metadata-taxonomy-picker": "^3.1.25",
"@box/metadata-template-browser": "^2.1.7",
"@box/metadata-template-editor": "^2.3.0",
"@box/metadata-view": "^1.53.26",
"@box/react-virtualized": "^9.22.3-rc-box.10",
"@box/readable-time": "^2.2.8",
Expand All @@ -154,6 +159,9 @@
"@chromatic-com/storybook": "^5.2.1",
"@commitlint/cli": "^19.8.0",
"@commitlint/config-conventional": "^19.8.0",
"@dnd-kit/core": "^6.1.0",

@jpan-box jpan-box Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just calling out, other box-internal parent apps may need to add these as new deps which they may not be happy about. just something to look out for when developing shared features -> buie. i assume you're working on this same task though so it may be you doing that work

"@dnd-kit/sortable": "^8.0.0",
"@dnd-kit/utilities": "^3.2.2",
"@eslint/eslintrc": "^3.1.0",
"@eslint/js": "^9.6.0",
"@formatjs/intl-pluralrules": "^1.5.2",
Expand Down Expand Up @@ -293,7 +301,8 @@
"webpack": "^5.105.4",
"webpack-bundle-analyzer": "^4.10.2",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^5.2.4"
"webpack-dev-server": "^5.2.4",
"yup": "^1.6.1"
},
"peerDependencies": {
"@box/activity-feed": "^2.3.12",
Expand All @@ -312,6 +321,7 @@
"@box/metadata-filter": "^1.80.23",
"@box/metadata-taxonomy-picker": "^3.1.8",
"@box/metadata-template-browser": "^2.1.7",
"@box/metadata-template-editor": "^2.3.0",
"@box/metadata-view": "^1.53.26",
"@box/react-virtualized": "^9.22.3-rc-box.10",
"@box/readable-time": "^2.2.8",
Expand All @@ -320,6 +330,9 @@
"@box/unified-share-modal": "^2.15.16",
"@box/uploads-manager": "^2.4.0",
"@box/user-selector": "^2.2.8",
"@dnd-kit/core": "^6.1.0",
"@dnd-kit/sortable": "^8.0.0",
"@dnd-kit/utilities": "^3.2.2",
"@hapi/address": "^2.1.4",
"@tanstack/react-virtual": "^3.13.12",
"axios": "^0.33.0",
Expand Down Expand Up @@ -363,7 +376,8 @@
"sass": "1.77.6",
"scroll-into-view-if-needed": "^2.2.31",
"tabbable": "^1.1.3",
"uuid": "^8.3.2"
"uuid": "^8.3.2",
"yup": "^1.6.1"
},
"resolutions": {
"@sigstore/core": "3.2.1",
Expand All @@ -375,6 +389,8 @@
"tar": "^7.5.19"
},
"msw": {
"workerDirectory": [".storybook/public"]
"workerDirectory": [
".storybook/public"
]
}
}
}
1 change: 1 addition & 0 deletions scripts/i18n.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = {
'@box/metadata-filter',
'@box/metadata-taxonomy-picker',
'@box/metadata-template-browser',
'@box/metadata-template-editor',
'@box/metadata-view',
'@box/readable-time',
'@box/threaded-annotations',
Expand Down
2 changes: 1 addition & 1 deletion scripts/jest/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ module.exports = {
testMatch: ['**/__tests__/**/*.test.+(js|jsx|ts|tsx)'],
testPathIgnorePatterns: ['stories.test.js$', 'stories.test.tsx$', 'stories.test.d.ts'],
transformIgnorePatterns: [
'node_modules/(?!(@box/activity-feed|@box/blueprint-web|@box/blueprint-web-assets|@box/box-ai-agent-selector|@box/box-ai-content-answers|@box/box-item-type-selector|@box/cldr-data|@box/collaboration-popover|@box/combobox-with-api|@box/content-field|@box/copy-input|@box/item-icon|@box/metadata-editor|@box/metadata-filter|@box/metadata-taxonomy-picker|@box/metadata-template-browser|@box/metadata-view|@box/react-virtualized/dist/es|@box/readable-time|@box/threaded-annotations|@box/tree|@box/types|@box/unified-share-modal|@box/uploads-manager|@box/user-selector)/)',
'node_modules/(?!(@box/activity-feed|@box/blueprint-web|@box/blueprint-web-assets|@box/box-ai-agent-selector|@box/box-ai-content-answers|@box/box-item-type-selector|@box/cldr-data|@box/collaboration-popover|@box/combobox-with-api|@box/content-field|@box/copy-input|@box/item-icon|@box/metadata-editor|@box/metadata-filter|@box/metadata-taxonomy-picker|@box/metadata-template-browser|@box/metadata-template-editor|@box/metadata-view|@box/react-virtualized/dist/es|@box/readable-time|@box/threaded-annotations|@box/tree|@box/types|@box/unified-share-modal|@box/uploads-manager|@box/user-selector)/)',
],
};
11 changes: 11 additions & 0 deletions src/api/Base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
HTTP_POST,
HTTP_PUT,
HTTP_DELETE,
METADATA_SCOPE_MODE_SCOPED,
} from '../constants';
import type { ElementsErrorCallback, APIOptions } from '../common/types/api';
import type APICache from '../utils/Cache';
Expand Down Expand Up @@ -59,6 +60,15 @@ class Base {
*/
metadataApiHost: ?string;

/**
* Namespace migration mode for the Box Metadata Namespaces API.
* Controls whether requests use legacy scopes ('SCOPED'), both ('MIGRATION'),
* or namespace-only ('FINAL'). Defaults to 'SCOPED'.
*
* @property {string}
*/
metadataNamespaceMode: string;

/**
* @property {string}
*/
Expand Down Expand Up @@ -118,6 +128,7 @@ class Base {
this.cache = options.cache || new Cache();
this.apiHost = options.apiHost || DEFAULT_HOSTNAME_API;
this.metadataApiHost = options.metadataApiHost;
this.metadataNamespaceMode = options.metadataNamespaceMode || METADATA_SCOPE_MODE_SCOPED;
this.uploadHost = options.uploadHost || DEFAULT_HOSTNAME_UPLOAD;
// @TODO: avoid keeping another copy of data in this.options
this.options = {
Expand Down
Loading
Loading