This repository was archived by the owner on May 26, 2022. It is now read-only.
XLSX Date Support / Fix for years beyond 2037 #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KiNgMaR, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
Contributor
Author
|
CLA signed. |
|
Verified that @KiNgMaR has just signed the CLA. Thanks, and we look forward to your contribution. |
Contributor
Author
|
Resolving the issues found by CI is in progress. |
Collaborator
There was a problem hiding this comment.
use camelcase for all variables
Collaborator
|
Good catch @KiNgMaR ! The fix looks good to me :) |
KiNgMaR
force-pushed
the
Fix-Dates-Beyond-2037
branch
3 times, most recently
from
905db3b to
88630a3
Compare
Contributor
Author
|
Final proposal pushed :) |
Collaborator
There was a problem hiding this comment.
keep comment "Fix for the erroneous leap year in Excel"
Collaborator
|
Minor comments, but overall looks good! |
This also fixes years < 1902 on 32-bit PHP systems.
KiNgMaR
force-pushed
the
Fix-Dates-Beyond-2037
branch
from
88630a3 to
4407cff
Compare
Contributor
Author
|
Diff updated! |
adrilo
added a commit
that referenced
this pull request
Dec 17, 2015
XLSX Date Support / Fix for years beyond 2037
Collaborator
|
Thanks @KiNgMaR ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dates where the unix timestamp grew higher than
PHP_INT_MAX(or maybe also above 2^31 on 64-bit PHP, I didn't test that) were mangled. The new unit test in the PR shows that. To fix the issue, directly pass the number of days instead of the unix timestamp into PHP's Date classes. Please review, any feedback is welcome.