This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Use ensure_packages to install dependencies#29
Merged
mattheath merged 1 commit intoboxen:masterfrom Mar 21, 2014
DarkHorseComics:ensure-packages
Merged
Use ensure_packages to install dependencies#29mattheath merged 1 commit intoboxen:masterfrom DarkHorseComics:ensure-packages
mattheath merged 1 commit intoboxen:masterfrom
DarkHorseComics:ensure-packages
Conversation
Member
|
Thanks @jameydeorio, I didn't even know that existed! Could you update the spec below, then we're good to merge? Homebrew is the default package provider, so everything's fine, but the spec is still expecting the provider to be explicitly defined: should contain_package(pkg).with_provider("homebrew")to should contain_package(pkg)Cheers! 🍺 |
Author
|
Spec updated! |
Member
|
Perfect, thanks! |
mattheath
added a commit
that referenced
this pull request
Mar 21, 2014
Use ensure_packages to install dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without using ensure_packages, anybody using other modules with the same requirements will have to jump through lots of annoying hoops to get their dependencies installed while avoiding duplicate package declaration errors from puppet.