Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

Conversation

@richaagarwal
Copy link

This command returns a list of database names that match the grep query. With the -A (no-align) option, the list of databases is incorrectly chomped on line breaks so that it appears that there are more database name matches than actually exist. Removing the -A option from this psql command appears to fix the problem.

@richaagarwal
Copy link
Author

@dgoodlad does this look OK to you? Not sure what the no-align option is intended for.

@seanknox
Copy link

seanknox commented Jan 7, 2015

👍. The Travis build failed due to API limits from Github, suspect if you rerun @richaagarwal it'll pass.

@richaagarwal
Copy link
Author

Hey @dgoodlad - I don't have permission to rerun Travis, but because the build failed due to API limits from GitHub (https://travis-ci.org/boxen/puppet-postgresql/jobs/46001230#L142), I think this is safe to merge in.

@seanknox
Copy link

@tarebyte can we get this merged in?

@tarebyte
Copy link
Contributor

I can't merge this from the UI. @richaagarwal can you rebase this against master?

@richaagarwal
Copy link
Author

@tarebyte Done. (And still failing due to GitHub API limits: https://travis-ci.org/boxen/puppet-postgresql/jobs/47565967#L130)

@tarebyte
Copy link
Contributor

@richaagarwal I'll run the tests locally just to confirm this works I've seen this problem in a few other modules as well.

@tarebyte
Copy link
Contributor

Works for me!

tarebyte added a commit that referenced this pull request Jan 20, 2015
Fix search for existing databases by removing no-align option
@tarebyte tarebyte merged commit 9d7211b into boxen:master Jan 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants