build: use official release of github.com/asaskevich/govalidator/v12#6
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including a major version bump for govalidator to v12, an update to jaeger-idl, and refreshed pseudo-versions for genproto. It also increases the Go version requirement to 1.26.0. Feedback indicates that bumping the Go version in a library's go.mod is a breaking change for consumers on older versions and should be reverted to 1.25.0 unless specific new language features are necessary.
WalkthroughThis PR updates the Go toolchain to 1.26.0, upgrades ChangesGo Dependency Updates
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🔕 Pre-merge checks override appliedThe pre-merge checks have been overridden successfully. You can now proceed with the merge. Overridden by ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 3: CI workflows are still using go-version "1.21" while go.mod now
specifies Go 1.26.0; update the GitHub Actions workflow files
`.github/workflows/test.yml`, `.github/workflows/format.yml`,
`.github/workflows/oidc-conformity.yml`, and
`.github/workflows/oidc-conformity-master.yml` to set the go-version values from
"1.21" to "1.26" (update the actions/setup-go step's go-version input) so CI
runs against the go.mod baseline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e6821d79-b39c-462e-beaa-4e25ebe6a564
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
authorize_helper.gogo.mod
12db7df to
1fbf133
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 6: The go.mod entry references a non-existent release
"github.com/asaskevich/govalidator/v12 v12.0.0"; replace it with a real
published release (e.g., use "github.com/asaskevich/govalidator v11.0.1" or
another valid tag) by updating the module line for
github.com/asaskevich/govalidator (remove the /v12 path if switching to v11) and
then run module tidy/get to refresh go.sum and ensure builds succeed; if you
intended to use the unreleased v12 changes, instead point to a specific commit
or wait for an official v12 tag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 58427c5b-336b-41fe-a44a-d7b05cb1b37a
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (6)
.github/workflows/format.yml.github/workflows/oidc-conformity-master.yml.github/workflows/oidc-conformity.yml.github/workflows/test.ymlauthorize_helper.gogo.mod

Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments
Summary by CodeRabbit