Skip to content

build: use official release of github.com/asaskevich/govalidator/v12#6

Merged
Philio merged 1 commit into
masterfrom
05-12-build_use_official_release_of_github.com_asaskevich_govalidator_v12
May 12, 2026
Merged

build: use official release of github.com/asaskevich/govalidator/v12#6
Philio merged 1 commit into
masterfrom
05-12-build_use_official_release_of_github.com_asaskevich_govalidator_v12

Conversation

@Philio
Copy link
Copy Markdown
Member

@Philio Philio commented May 12, 2026

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain to a newer stable release for improved performance and language features.
    • Upgraded core validation and tracing libraries to their latest stable major releases.
    • Refreshed API/protocol-related dependencies to maintain compatibility and security.
    • CI workflows adjusted to use the updated Go toolchain.

Review Change Stack

Review Change Stack

Copy link
Copy Markdown
Member Author

Philio commented May 12, 2026

@Philio Philio mentioned this pull request May 12, 2026
6 tasks
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, including a major version bump for govalidator to v12, an update to jaeger-idl, and refreshed pseudo-versions for genproto. It also increases the Go version requirement to 1.26.0. Feedback indicates that bumping the Go version in a library's go.mod is a breaking change for consumers on older versions and should be reverted to 1.25.0 unless specific new language features are necessary.

Comment thread go.mod
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Walkthrough

This PR updates the Go toolchain to 1.26.0, upgrades github.com/asaskevich/govalidator to v12 with its versioned import path, updates GitHub Actions workflows to use Go 1.26, and bumps several indirect dependencies in go.mod.

Changes

Go Dependency Updates

Layer / File(s) Summary
Go Toolchain Version & CI Workflows
go.mod, .github/workflows/*
go directive raised from 1.25.0 to 1.26.0; workflow actions/setup-go steps updated to use Go 1.26.
govalidator Dependency & Import
go.mod, authorize_helper.go
Direct dependency upgraded to github.com/asaskevich/govalidator/v12 v12.0.0; import in authorize_helper.go updated to github.com/asaskevich/govalidator/v12.
Transitive Dependency Updates
go.mod
Indirect github.com/jaegertracing/jaeger-idl bumped to v0.7.0; google.golang.org/genproto/googleapis/api and /rpc pseudo-versions updated to newer 20260511... entries.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Modules hop to versions new,
govalidator wears v12 blue,
Toolchain climbs to twenty-six,
Workflows updated, transitive picks—
A little rabbit cheer for the view!


🔕 Pre-merge checks override applied

The pre-merge checks have been overridden successfully. You can now proceed with the merge.

Overridden by @Philio via checkbox on 2026-05-12T01:15:54.001Z.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Comments ❌ Error [IGNORED] Code Rabbit identified that govalidator/v12 v12.0.0 does not exist as an official release. No response or reasoning has been provided in the PR to address this critical comment. The PR must either address the Code Rabbit comment by explaining the v12.0.0 availability, or replace the dependency with an existing version (e.g., v11.0.1) and update the import accordingly.
Description check ⚠️ Warning The PR description is entirely template placeholder text with no actual content, missing the required big-picture explanation, related issue/design document reference, and implementation details. Replace template placeholders with concrete information: explain why the official govalidator/v12 release is being adopted, reference any related issues if applicable, and provide implementation details about the upgrade.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating to use the official release of govalidator/v12, which directly corresponds to the primary dependency upgrade shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Mockery ✅ Passed Project does not use Mockery; it uses mockgen (golang/mock). No Mockery configuration file exists. The custom check is not applicable to this project.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 05-12-build_use_official_release_of_github.com_asaskevich_govalidator_v12

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 3: CI workflows are still using go-version "1.21" while go.mod now
specifies Go 1.26.0; update the GitHub Actions workflow files
`.github/workflows/test.yml`, `.github/workflows/format.yml`,
`.github/workflows/oidc-conformity.yml`, and
`.github/workflows/oidc-conformity-master.yml` to set the go-version values from
"1.21" to "1.26" (update the actions/setup-go step's go-version input) so CI
runs against the go.mod baseline.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e6821d79-b39c-462e-beaa-4e25ebe6a564

📥 Commits

Reviewing files that changed from the base of the PR and between e9b943f and 12db7df.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • authorize_helper.go
  • go.mod

Comment thread go.mod
@Philio Philio changed the base branch from 05-09-fix_missing_hint_check to graphite-base/6 May 12, 2026 00:55
@Philio Philio force-pushed the 05-12-build_use_official_release_of_github.com_asaskevich_govalidator_v12 branch from 12db7df to 1fbf133 Compare May 12, 2026 00:55
@Philio Philio changed the base branch from graphite-base/6 to master May 12, 2026 00:55
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 6: The go.mod entry references a non-existent release
"github.com/asaskevich/govalidator/v12 v12.0.0"; replace it with a real
published release (e.g., use "github.com/asaskevich/govalidator v11.0.1" or
another valid tag) by updating the module line for
github.com/asaskevich/govalidator (remove the /v12 path if switching to v11) and
then run module tidy/get to refresh go.sum and ensure builds succeed; if you
intended to use the unreleased v12 changes, instead point to a specific commit
or wait for an official v12 tag.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 58427c5b-336b-41fe-a44a-d7b05cb1b37a

📥 Commits

Reviewing files that changed from the base of the PR and between 12db7df and 1fbf133.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • .github/workflows/format.yml
  • .github/workflows/oidc-conformity-master.yml
  • .github/workflows/oidc-conformity.yml
  • .github/workflows/test.yml
  • authorize_helper.go
  • go.mod

Comment thread go.mod
@Philio Philio merged commit 81056c6 into master May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant