feat(cli): add --rootfs flag to run/create command [WIP]#549
Open
ruilong1999 wants to merge 4 commits into
Open
feat(cli): add --rootfs flag to run/create command [WIP]#549ruilong1999 wants to merge 4 commits into
ruilong1999 wants to merge 4 commits into
Conversation
Adds RootfsFlags carrying optional IMAGE positional and optional --rootfs PATH flag with clap ArgGroup(required=true, multiple=false), so exactly one source is required and they're mutually exclusive. CLI-side fail-fast validation checks the path exists, is a directory, and contains an oci-layout file; deeper OCI parsing stays in the runtime's existing image_manager.load_from_local. Unblocks offline/air-gapped use of pre-exported OCI bundles via the CLI; previously only the SDKs and REST layer exposed this. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
) Adds integration tests for both run and create: - IMAGE and --rootfs mutually exclusive - neither argument provided - --rootfs path does not exist - --rootfs path is not a directory - --rootfs path missing oci-layout These don't boot a box (no real OCI bundle needed) so they're safe to run on the standard CI matrix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Updates synopsis, option tables, and examples in both the CLI README and the CLI reference. Adds a RootfsFlags section to the shared flag-groups reference, with a note about using -- before COMMAND when combining --rootfs with boxlite run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CI's `make fmt:check:rust` (cargo fmt --all -- --check) flagged 7 formatting drift spots introduced by the boxlite-ai#449 commits. Applies the exact diff rustfmt emitted in github.com/boxlite-ai/boxlite/actions/runs/26084049396 — no behaviour changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #449
Added
--rootfsflag to the CLIrun/createcommand to allow usersto specify a custom root filesystem path.