Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0da9047edf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mv "${binary_path}" "${install_path}" | ||
|
|
||
| "${install_path}" --version >/dev/null 2>&1 || fail "Installed binary failed validation: ${install_path}" |
There was a problem hiding this comment.
Validate binary before moving it into install path
The installer overwrites bin_dir/ceeker before verifying the new binary can run, so if a checksummed release artifact is incompatible on the host (for example, a bad or wrong-arch upload), the script exits with validation failure after already clobbering the previous working install. Validate the extracted binary first (or only replace atomically after successful validation) to avoid leaving users with a broken ceeker.
Useful? React with 👍 / 👎.
Summary
install.shthat downloads the matching GitHub Release tarball, verifieschecksums.txt, and installsceekermake test/make cidocs/project_docs/ceeker-install-script/plan.mdTesting