Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 365910cc02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (defn- layout-line-count | ||
| "Returns the number of lines used by the static screen chrome." | ||
| [compact?] | ||
| (if compact? 5 7)) |
There was a problem hiding this comment.
Account for wrapped chrome lines in height budget
layout-line-count assumes the non-session UI always uses exactly 5/7 lines, but footer-line (and occasionally header-line) can exceed the terminal width and wrap to extra rows. On narrow terminals (for example compact view around 40 columns), this overestimates available-lines, so visible-session-blocks still emits too many session lines and the final screen output overflows, which can scroll the selected item out of view despite the new overflow logic. The height budget should be computed from wrap-aware rendered line counts rather than fixed constants.
Useful? React with 👍 / 👎.
概要
確認済み
補足