Skip to content

feat: agent list overflow scroll#64

Merged
boxp merged 3 commits intomainfrom
fix/scroll-overflow-agent-list
Mar 25, 2026
Merged

feat: agent list overflow scroll#64
boxp merged 3 commits intomainfrom
fix/scroll-overflow-agent-list

Conversation

@boxp
Copy link
Copy Markdown
Owner

@boxp boxp commented Mar 25, 2026

概要

  • agent 一覧が terminal height を超える場合に、選択中の agent を含む範囲だけ表示するスクロール表示を追加
  • table view / card view の両方で overflow 時の表示窓切り替えに対応
  • 実装方針と検証内容を docs/project_docs/fix-scroll-overflow-agent-list/plan.md に追加

確認済み

  • clojure -M:test -n ceeker.tui.view-test
  • clojure -M:test -n ceeker.tui.app-test
  • git diff --check

補足

  • ローカル make ci は今回の変更と無関係な既存 3 テスト失敗で停止
  • GitHub Actions 上で PR の CI を確認し、PR 側で通る場合は local のみ失敗する要因を別途調査する

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 365910cc02

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ceeker/tui/view.clj Outdated
Comment on lines +330 to +333
(defn- layout-line-count
"Returns the number of lines used by the static screen chrome."
[compact?]
(if compact? 5 7))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Account for wrapped chrome lines in height budget

layout-line-count assumes the non-session UI always uses exactly 5/7 lines, but footer-line (and occasionally header-line) can exceed the terminal width and wrap to extra rows. On narrow terminals (for example compact view around 40 columns), this overestimates available-lines, so visible-session-blocks still emits too many session lines and the final screen output overflows, which can scroll the selected item out of view despite the new overflow logic. The height budget should be computed from wrap-aware rendered line counts rather than fixed constants.

Useful? React with 👍 / 👎.

@boxp boxp merged commit 84b3c97 into main Mar 25, 2026
6 checks passed
@boxp boxp deleted the fix/scroll-overflow-agent-list branch March 25, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant