Add total row to people table showing number of beneficiaries#730
Merged
Add total row to people table showing number of beneficiaries#730
Conversation
Contributor
Author
|
@pylipp 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Copilot
AI
changed the title
[WIP] Add total row to people table
Add total row to people table showing number of beneficiaries
Aug 12, 2025
HaGuesto
approved these changes
Aug 19, 2025
Co-authored-by: pylipp <10617122+pylipp@users.noreply.github.com>
027ae46 to
acbd05d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a totals counter for the people table, similar to the existing functionality in the stock table. The counter displays the number of beneficiaries being shown and is influenced by applied filters.
Changes Made
Core Implementation:
include/people.phpthat counts displayed beneficiaries after all filteringKey Features:
firstline/listfootertemplate pattern as stock.php for consistencyTesting:
5_3_People_Totals_Test.js) to verify functionalityExample
Before: People table had no totals information
After: People table shows totals like the stock table:
The implementation ensures the counter updates correctly when users apply filters, search, or use tags, providing the same user experience as the existing stock table functionality.
Fixes #729.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cs.symfony.comcurl -L REDACTED -o php-cs-fixer.phar(dns block)https://api.github.com/repos/Nevay/spi/zipball/e7078767866d0a9e0f91d3f9d42a832df5e39002/usr/bin/php8.3 -n -c /tmp/zje3Wi /usr/bin/composer install(http block)https://api.github.com/repos/Nyholm/psr7/zipball/a71f2b11690f4b24d099d6b16690a90ae14fc6f3/usr/bin/php8.3 -n -c /tmp/zje3Wi /usr/bin/composer install(http block)https://api.github.com/repos/composer/semver/zipball/4313d26ada5e0c4edfbd1dc481a92ff7bff91f12/usr/bin/php8.3 -n -c /tmp/zje3Wi /usr/bin/composer install(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.