Update facebook.js#4
Open
fredericpetitdev wants to merge 5 commits into
Open
Conversation
Contributor
fredericpetitdev
commented
Dec 31, 2014
fredericpetitdev
commented
- adding support for data-width, default to 250 if it's not specified
- fixing errors
- adding link documentation
adding support for data-width, default to 250 if it's not specified
because with actual code, when we set to false, sharing is even possible, so with new code it's seems works good, default to true
Owner
There was a problem hiding this comment.
250px is only applicable for "standard" layout, by setting width default value to this in other layouts it might cause problems. I suggest adding width to template only when it's provided.
Like:
if (width) {
// inject data-width="{{width}}" to template
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.