Skip to content

Remove top level --stack argument #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dboreham merged 1 commit into from
Apr 4, 2026
Merged

Remove top level --stack argument #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ These options can be used with any command:
|--------|------|-------------|---------|
| `--log-file` | TEXT | Log to file (default stdout/stderr) | - |
| `--debug` | FLAG | Enable debug options | From config |
| `--stack` | TEXT | Name or path of the stack | - |
| `--profile` | TEXT | Configuration profile to use | `config` |
| `--verbose` | FLAG | Log extra details | False |
| `--quiet` | FLAG | Suppress unnecessary log output | False |
Expand Down
3 changes: 0 additions & 3 deletions src/stack/build/build_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,6 @@ def build_containers(parent_stack,
@click.pass_context
def command(ctx, stack, include, exclude, git_ssh, build_policy, extra_build_args, dont_pull_images, publish_images, image_registry, target_arch):
"""build stack containers"""
if not stack:
stack = ctx.obj.stack_path

stack = resolve_stack(stack)
build_containers(stack,
build_policy,
Expand Down
3 changes: 0 additions & 3 deletions src/stack/init/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,6 @@ def command(
deploy_to,
)

if not stack:
stack = ctx.obj.stack_path

top_stack_config = resolve_stack(stack)
required_stacks = top_stack_config.get_required_stacks_paths()
config_variables = {}
Expand Down
5 changes: 2 additions & 3 deletions src/stack/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
@click.group(context_settings=CONTEXT_SETTINGS, cls=StackCLI)
@click.option("--log-file", help="Log to file (default stdout/stderr)")
@click.option("--debug", help="enable debug options", is_flag=True, default=get_config_setting("debug", False))
@click.option("--stack", help="name or path of the stack")
@click.option(
"--profile", help="name of the configuration profile to use", default=os.environ.get("STACK_CONFIG_PROFILE", "config")
)
Expand All @@ -54,7 +53,7 @@
# TEL: Hide these for now, until we make sure they are consistently implemented.
@click.option("--dry-run", is_flag=True, default=False, hidden=True)
@click.pass_context
def cli(ctx, profile, quiet, verbose, log_file, dry_run, debug, stack):
def cli(ctx, profile, quiet, verbose, log_file, dry_run, debug):
"""BPI stack"""

if log_file:
Expand All @@ -68,7 +67,7 @@ def cli(ctx, profile, quiet, verbose, log_file, dry_run, debug, stack):
elif quiet:
log_level = LOG_LEVELS["warn"]

command_options = CommandOptions(profile, stack, log_level, log_file, dry_run, debug, quiet)
command_options = CommandOptions(profile, None, log_level, log_file, dry_run, debug, quiet)
opts.o = command_options
ctx.obj = command_options

Expand Down
Loading