Improve event signaling / sub-process start #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially removing dead, untested code.
This introduces an internal ref for catch events. That reference ensures we can identify individual events when triggering them via UI. This explicitly also works if the events would be technically similar (two message events both not referencing a message, two non start events), thereby mitigating a UX regression introduced with event scopes and subscriptions (#103). Also reverts related example change (866a6c0). Closes #103
nikku
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
15d1406 restores the pre event-scopes behavior to signal individual start events that would technically be similar (#103):
acdae24 ensures we follow the BPMN spec and start all "start event like" activites inside a sub-process:
Closes #103
A general recommendation is to NOT have more than one start event. Restoring the BPMN spec SHALL behavior should drive the point: