This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Release v2.1.1 #84
Merged
Release v2.1.1 #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bp 0536 fix so exception
Bp 0539 sort events
…o load all events" This reverts commit 1e6b22d.
Bp 0536 fix so exception
Improve performance
Bp 0554 fix query edit
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
hpibptlab
reviewed
Jul 18, 2017
| EventQuery oldEventQuery = PersistenceAdapterImpl.getInstance().getEventQuery(oldEventQueryId); | ||
| String oldEventQueryString = oldEventQuery.getQuery(); | ||
|
|
||
| if (oldEventQuery == null) { |
There was a problem hiding this comment.
Change this condition so that it does not always evaluate to "false" 
updates version numbers
frederike-ramin
approved these changes
Jul 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.