Skip to content

Support for tokenize Japanese document with emojis #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
momeemt merged 5 commits into from
Mar 17, 2024
Merged

Support for tokenize Japanese document with emojis #27

momeemt merged 5 commits into from
Mar 17, 2024

Conversation

@uekann
Copy link
Contributor

@uekann uekann commented Mar 17, 2024

No description provided.

@uekann uekann requested a review from momeemt as a code owner March 17, 2024 14:01
@uekann uekann linked an issue Mar 17, 2024 that may be closed by this pull request
Support for tokenize in Japanese documentation #25
Closed
momeemt
momeemt requested changes Mar 17, 2024
View reviewed changes
@uekann
Copy link
Contributor Author

uekann commented Mar 17, 2024

Sorry, I forgot to erase these comments.
I fixed it!

@uekann
Revert "add debug setting"
3ec565e 
This reverts commit 830adfb.
@momeemt
Copy link
Member

momeemt commented Mar 17, 2024

@uekann
Thank you for your handling!
You should keep pull requests as simple as possible, because reviewers can easily see through all changes, and we can quickly revert a change if we discover a serious bug. So I want you to split into more than two pull requests if there are multiple changes. You can execute git revert or git cherry-pick to move another change to a new branch.
I'll merge what fixes the Unicode character handling, but adding the debug configuration should be reviewed another time.

momeemt
momeemt approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@momeemt momeemt merged commit 74944b0 into main Mar 17, 2024
@momeemt momeemt deleted the fix/support-japanese-tokenize branch April 25, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@momeemt momeemt momeemt approved these changes

Assignees

@uekann uekann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for tokenize in Japanese documentation

3 participants

@uekann @momeemt