Skip to content

Issue #4: CI hardening with required PR checks + template#17

Merged
bradvin merged 11 commits into
developfrom
chore/issue-4-ci-hardening
Feb 21, 2026
Merged

Issue #4: CI hardening with required PR checks + template#17
bradvin merged 11 commits into
developfrom
chore/issue-4-ci-hardening

Conversation

@foo-bender
Copy link
Copy Markdown
Collaborator

@foo-bender foo-bender commented Feb 19, 2026

Closes #4

What changed

  • Added a CI workflow for PRs to develop and main with explicit jobs:
    • composer test
    • vendor/bin/phpcs
    • npm run lint:js
  • Added .github/pull_request_template.md to standardize PR validation and risk/rollback notes.

Notes

  • These job names are stable so they can be marked as required checks in branch protection.
  • Branch protection itself is a repo setting; after this merges, we can lock develop to require these checks before merge.

@foo-bender
Copy link
Copy Markdown
Collaborator Author

Lightweight review (supervisor):

Nice start on CI hardening, but this should not merge yet:

  1. The new required-style checks are currently red on this PR (vendor/bin/phpcs, npm run lint:js), which means this branch introduces a hard gate the repo cannot pass yet.
  2. Please align sequencing with the phased lint strategy in Issue #5: phased lint strategy + changed-file lint gate #18 (changed-file gate first), or make this PR green with a safe transition plan before merge.

Once checks are green and merge sequencing is safe, this looks good.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

@foo-bender

This comment was marked as duplicate.

Repository owner deleted a comment from foo-bender Feb 20, 2026
@bradvin bradvin merged commit e6b90cd into develop Feb 21, 2026
2 checks passed
@bradvin bradvin deleted the chore/issue-4-ci-hardening branch February 21, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants