Skip to content

docs(nap): add archiveDecisions() contract comment#648

Merged
bradygaster merged 1 commit intobradygaster:devfrom
diberry:squad/37-nap-jsdoc
Mar 27, 2026
Merged

docs(nap): add archiveDecisions() contract comment#648
bradygaster merged 1 commit intobradygaster:devfrom
diberry:squad/37-nap-jsdoc

Conversation

@diberry
Copy link
Copy Markdown
Collaborator

@diberry diberry commented Mar 27, 2026

JSDoc contract for archiveDecisions() documenting entry format, no-data-loss invariant, threshold/fallback strategy, and return semantics. Comment-only, zero code changes.

Closes diberry#37

@bradygaster — postmortem action item A8. Minimal JSDoc addition to nap.ts.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster merged commit a31fded into bradygaster:dev Mar 27, 2026
3 checks passed
larsontim12 pushed a commit to larsontim12/squad that referenced this pull request Mar 27, 2026
…er#650)

* feat: REPL UX polish — figlet banner, proper-case names, keyword emoji, 80-col wrap, activity hints

- Add figlet ASCII art SQUAD banner in header (App.tsx)
- Fix agent name casing: SessionRegistry uses case-insensitive keys, preserves display names (sessions.ts)
- Add keyword-based role emoji fallback matching in getRoleEmoji (lifecycle.ts)
- Add extractAgentHint() to parse coordinator text for specific task descriptions (index.ts)
- Cap content width at 80 columns across App.tsx, MessageStream.tsx, AgentPanel.tsx
- Remove [system] prefix from system messages in MessageStream
- Add slash command passthrough while processing (InputPrompt.tsx)
- Pin header to top via Ink Static block, simplified header content
- Register agents with proper case names, use display names in activity hints
- Update tests: 192 passing

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: wire REPL telemetry — EventBus bridge, StreamingPipeline, agent metrics, model display

Wire all defined OTel instrumentation into the REPL code path:

- Pass EventBus to initSquadTelemetry() so EventBus→OTel bridge activates (bradygaster#645)
- Instantiate StreamingPipeline and feed message_delta/usage events for token
  and response latency metrics (TTFT, duration, tokens/sec) (bradygaster#646)
- Call recordAgentSpawn/Duration/Error/Destroy from dispatch handlers (bradygaster#647)
- Add model field to AgentSession, display model name in AgentPanel (bradygaster#648)
- Enable shell metrics when OTel endpoint is configured (no longer requires
  SQUAD_TELEMETRY=1) (bradygaster#649)
- Export RuntimeEventBus from SDK barrel for REPL consumption
- Listen for usage events to capture model name and feed to StreamingPipeline
- Update tests: replace stale [WORK]/[STREAM] assertions, update banner/header
  checks for figlet art, update source-code parsing tests for simplified header

Closes bradygaster#644, bradygaster#645, bradygaster#646, bradygaster#647, bradygaster#648, bradygaster#649

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(nap): Add contract comment documenting archiveDecisions() invariants

2 participants