Conversation
Adds the Copilot PR review workflow skill covering the full pipeline: reading reviews, critical evaluation, lockout routing, thread resolution via GraphQL, and CI verification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
force-pushed
the
squad/skill-copilot-pr-review-workflow
branch
from
8a276da to
67c014d
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new Squad skill documenting an end-to-end workflow for handling Copilot PR review comments (read/triage/route fixes/verify CI/resolve threads), based on recent PR review cycles.
Changes:
- Introduces a new skill document:
.squad/skills/copilot-pr-review-workflow/SKILL.md - Documents review-thread reading (MCP + GraphQL), lockout routing, CI verification, and thread resolution steps
- Captures common Copilot reviewer patterns and anti-patterns for PR hygiene
| name: "copilot-pr-review-workflow" | ||
| description: "Complete pipeline for handling Copilot PR reviewer bot comments ΓÇö from reading reviews to resolving threads" | ||
| domain: "pr-review" |
There was a problem hiding this comment.
The file contains mojibake characters (e.g., "ΓÇö") in the YAML frontmatter description, which indicates an encoding/charset issue and will render incorrectly in docs. Replace these with the intended characters (e.g., an em dash "—") and ensure the file is saved as UTF-8.
| tools: | ||
| - name: "pull_request_read" | ||
| description: "GitHub MCP tool to read PR review comments" | ||
| when: "Reading Copilot review threads with get_review_comments method" | ||
| - name: "gh api graphql" |
There was a problem hiding this comment.
The MCP tool name and invocation format here don’t match the established convention used in the existing PR review skills (e.g., .squad/skills/pr-review-response/SKILL.md uses github-mcp-server-pull_request_read with a YAML-style argument block). If agents copy/paste pull_request_read(...) it may not work in this repo’s tool environment; consider aligning the tool name and example call format with the existing skill to avoid broken instructions.
| ## Scope | ||
|
|
||
| ✅ THIS SKILL PRODUCES: | ||
| - A decision on which comments to fix vs push back on | ||
| - Correctly routed fix assignments (respecting lockout) | ||
| - Resolved review threads after verified fixes | ||
| - Green CI confirmation | ||
|
|
||
| ❌ THIS SKILL DOES NOT PRODUCE: | ||
| - New tests (unless a comment specifically requests one) | ||
| - Refactors beyond what the comment identifies | ||
| - Changes to `.squad/` files (keep PR hygiene separate) |
There was a problem hiding this comment.
More mojibake characters appear in the section headers (e.g., "Γ£à", "Γ¥î") where this likely intended to be "✅" / "❌" markers. This will render as garbage text; replace with the intended symbols (or ASCII equivalents like "+"/"-") and ensure UTF-8 encoding.
| Session examples: | ||
| - PR #760: **Network** authored → **FIDO** fixed Copilot comments | ||
| - PR #762: **EECOM** authored → **CONTROL** fixed Copilot comments |
There was a problem hiding this comment.
The session example lines contain mojibake ("ΓåÆ") where an arrow ("→") is likely intended. Since this skill is meant to be copy/paste friendly, it’s worth fixing all such occurrences to avoid confusing or broken rendering.
|
|
||
| Run these checks BEFORE submitting for review to reduce noise: | ||
|
|
||
| - No `.squad/` files in the diff |
There was a problem hiding this comment.
This checklist item is written as an absolute ("No .squad/ files in the diff"), but this repo does have legitimate PRs that intentionally change .squad/ (like this one). Consider rewording to something like “No unrelated .squad/ changes” or “Avoid mixing .squad/ changes with product code” to keep the guidance accurate.
| - No `.squad/` files in the diff | |
| - No unrelated `.squad/` changes in the diff |
| - No branch stacking (PR only contains its own commits) | ||
| - Changeset present if CLI/SDK source changed | ||
| - File count matches intent (Γëñ10 for most fixes) | ||
|
|
||
| ## Agent Workflow | ||
|
|
||
| 1. **READ** ΓÇö Fetch review threads using `pull_request_read` or GraphQL | ||
| 2. **TRIAGE** ΓÇö Categorize each comment (factual error / edge case / style / over-engineering) |
There was a problem hiding this comment.
The file includes additional mojibake in numeric/comparison text (e.g., "Γëñ10") and several em-dash occurrences ("ΓÇö"). These should be replaced with the intended symbols (e.g., "≤10" and "—") and the file should be normalized to UTF-8 so future edits don’t reintroduce encoding corruption.
Summary
Adds a new skill at .squad/skills/copilot-pr-review-workflow/SKILL.md\ capturing the complete Copilot PR reviewer comment pipeline.
What this skill teaches agents:
Anti-patterns documented:
Confidence: medium (confirmed across PRs #756, #760, #762)
Source: earned (real PR review cycles)
Working as Procedures (Prompt Engineer).