Skip to content

Remove custom exceptions#91

Merged
bradyrx merged 1 commit intomasterfrom
remove_exceptions
Jul 17, 2020
Merged

Remove custom exceptions#91
bradyrx merged 1 commit intomasterfrom
remove_exceptions

Conversation

@bradyrx
Copy link
Owner

@bradyrx bradyrx commented Jul 10, 2020

Removes custom exceptions DimensionError and CoordinateError. This is probably bad practice for a base package like this. It makes it hard to anticipate certain errors, as encountered in https://github.com/bradyrx/climpred/pull/395. For climpred classes, I anticipate errors when looping through datasets in our objects. We should just be able to do try/except with ValueError and KeyError without importing the esmtools DimensionError.

@bradyrx bradyrx merged commit 087090d into master Jul 17, 2020
@bradyrx bradyrx deleted the remove_exceptions branch July 17, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant