Translations improvement / Added German translations #23
Conversation
|
Yes, Gary, it matters on this area: in load_ functions the unique id string is needed, otherwise it can under some circumstances pull an "random" id from plugin slug etc. also added domain path to plugin header, --> you only need to remove the "old" .pot file "blazer-six-gist-oembed" |
|
Codestyling Localization plugin has no more error messages with my changes included. Thanks, Dave :) |
There was a problem hiding this comment.
Should "Raw Key" have been left in the translation here?
There was a problem hiding this comment.
Maybe, don't know how to properly handle this in other languages like German, seems like a special term, and I should change it back - thanks for the feedback :)
|
Can you please also pull against dev branch, rather than master? Thanks. |
There was a problem hiding this comment.
Does plugin_dir_path() not give the same result as dirname(plugin_basename())?
There was a problem hiding this comment.
No, does not work - had this with lots of other plugins already, only the change brings it to work.... "load_plugin_textdomain()" requires relative path depending on plugin dir, maybe plugin_dir_path() is absolute or one level to high? It just does not work...
|
Just pulled/pushed in dev branch again and made 2nd pull request, also with your suggested changes/corrections |
|
Closing in favour of merged #24. |
2 participants
No description provided.