Skip to content

Conversation

@GaryJones
Copy link
Collaborator

This somewhat mirrors WP itself, with classes being held in a [wp-]includes directory.

bradyvercher added a commit that referenced this pull request Nov 1, 2013
Move included classes into an includes directory.
@bradyvercher bradyvercher merged commit f487b00 into bradyvercher:develop Nov 1, 2013
@bradyvercher
Copy link
Owner

This is how I handle pretty much all my plugins, so I like this change.

@GaryJones GaryJones deleted the feature/includes branch November 1, 2013 15:00
@GaryJones
Copy link
Collaborator Author

With usually only a few class files, I've not been too worried, and I didn't have a logical pattern on what should go where. Then:

a) I've been looking more at package.json, Grunt files, .jshintrc and other development / build-related files. Having them potentially in root then makes putting classes into a subfolder.

b) it occurred to me to follow WP itself for the directory name(s). Instead of lib, inc or other variations, stick with includes, which is used in both the WP root (with a wp- prefix) and inside wp-admin.

With those two realisations, my plugins are going to be heading that way too.

@GaryJones GaryJones added this to the 2.0.2 milestone Apr 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants