enable resultcaching for ViT models from timm#2235
Merged
KartikP merged 1 commit intobrain-score:masterfrom Jan 8, 2026
Merged
enable resultcaching for ViT models from timm#2235KartikP merged 1 commit intobrain-score:masterfrom
KartikP merged 1 commit intobrain-score:masterfrom
Conversation
Collaborator
|
Thanks for this @KogniJannis this looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the timm model plugin checked if a model is a ViT and if yes, disabled caching of extracted activations. This was because of the problem described in #1232 and addressed in #2164 which merged. Therefore, I think we should be able to enable result caching now.