Skip to content

Syncing from upstream OCA/queue (19.0)#547

Merged
bt-admin merged 20 commits intobrain-tec:19.0from
OCA:19.0
Apr 10, 2026
Merged

Syncing from upstream OCA/queue (19.0)#547
bt-admin merged 20 commits intobrain-tec:19.0from
OCA:19.0

Conversation

@bt-admin
Copy link
Copy Markdown

bt_gitbot

RLeeOSI and others added 20 commits March 23, 2026 13:30
Every time a job is done, even if it is not part of a graph, it runs a
query to look for dependents to enqueue. Storing the dependent uuids in
the "dependencies" field was on purpose to know that we have no further
jobs in the graph and that we can skip the check entirely and have no
overhead in this case.

It looks like an oversight, we can add the missing condition.
In this case, when a module adds a value in context, the tests fail
It is forbidden to commit inside a job, because it releases the job lock
and can cause it to start again, while still being run, by the dead jobs
requeuer. For some use cases, it may actually be legitimate, or at least
be needed in the short term before actual updates in the code.

A new option on the job function, false by default, allow to run the job
in a new transaction, at the cost of an additional connection +
transaction overhead.

Related to #889
False on new databases, True on existing databases.
Should always be False by default on future versions.
As the controller changes env on Job instances.
…ethod

We add the `_subscribe_job_creator` method in `queue.job` which will return True for the cases where we want to subscribe the job creator, False otherwise.
Signed-off-by guewen
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: queue-19.0/queue-19.0-queue_job
Translate-URL: https://translation.odoo-community.org/projects/queue-19-0/queue-19-0-queue_job/
@bt-admin bt-admin added the 19.0 label Apr 10, 2026
@bt-admin bt-admin merged commit fc00a91 into brain-tec:19.0 Apr 10, 2026
4 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 69.76744% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.65%. Comparing base (0c942e5) to head (8da22fc).
⚠️ Report is 25 commits behind head on 19.0.

Files with missing lines Patch % Lines
queue_job/controllers/main.py 13.33% 11 Missing and 2 partials ⚠️
queue_job/job.py 65.38% 8 Missing and 1 partial ⚠️
queue_job/models/queue_job.py 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             19.0     #547      +/-   ##
==========================================
+ Coverage   82.35%   82.65%   +0.30%     
==========================================
  Files          52       52              
  Lines        4193     4249      +56     
  Branches      372      384      +12     
==========================================
+ Hits         3453     3512      +59     
+ Misses        671      661      -10     
- Partials       69       76       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants