enh: measurement table improvements #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also leaving myself a note to remember to run
|
Contributor
Author
|
Okay - ready for review @eugenegkim. Tested locally by renaming files from one subject, and now preproc data has been renamed on the nan, but want to merge this before running it there. |
eilidhmacnicol
changed the title
This was
linked to
issues
Mar 18, 2025
Closed
eugenegkim
approved these changes
Mar 18, 2025
Contributor
eugenegkim
left a comment
eugenegkim
left a comment
There was a problem hiding this comment.
Looks good to me.
One thing to consider adding in the future: having utils.parse_kv look for a keyless suffix at the end of a filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
Had to implement parsing for flexibility of the output table, so also fixes #1 but this is a half baked( i.e., doesn't extend to argprep.py so would need to be added in another PR)
WIP because it needs to be tested tomorrow, but the dataset I'm working on doesn't have a key-value pair for section, (e.g.
slide-11_01should beslide-11_section-01so that we can take advantage of the section replicates)Will update once this is done and ask @eugenegkim formally for a review when this is ready to merge