ENH: field prep #20
Open
ENH: field prep #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 434e46d.
eilidhmacnicol
force-pushed
the
enh/flatfield_prep
branch
from
85684cc to
b399512
Compare
Contributor
Author
|
So after an offline conversation with @eugenegkim, processing for these fields should be done the same way, so I'm going to refactor this so that we don't need to specify flat field or dark field |
eugenegkim
approved these changes
May 9, 2025
Contributor
eugenegkim
left a comment
eugenegkim
left a comment
There was a problem hiding this comment.
Sorry for the delay. Looks good, no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Currently (ostensibly) works for flat field correction, but darkfield is still not implemented at the time this PR is opened