2025 Archive#77
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a pre-built static “2025 archive” site under public/2025 so it can be served alongside the main BrainHack Vanderbilt site.
Changes:
- Added archived 2025 build artifacts (HTML, manifest, JS/CSS/media/assets) under
public/2025/. - Updated home page greeting copy.
- Tweaked deployment workflow and updated
package-lock.json.
Reviewed changes
Copilot reviewed 7 out of 68 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/Home/Home.js | Changes hero greeting text. |
| public/2025/index.html | Adds archived 2025 entry HTML that loads the archived JS/CSS. |
| public/2025/manifest.json | Adds archived web app manifest for 2025 archive. |
| public/2025/asset-manifest.json | Adds CRA asset manifest for 2025 archive build output. |
| public/2025/static/js/main.6c178bc1.js.LICENSE.txt | Adds license aggregation for archived JS bundle. |
| public/2025/static/js/488.82df7a3f.chunk.js | Adds archived JS chunk. |
| public/2025/static/js/488.82df7a3f.chunk.js.map | Adds source map for archived JS chunk. |
| public/2025/static/media/pre.d4812f51c8c80976eaab.svg | Adds archived SVG asset (hashed path). |
| public/2025/assets/pre.svg | Adds un-hashed SVG copy in archive assets. |
| public/2025/assets/home-bg.jpg | Adds archived background image. |
| public/2025/assets/vandyhacks_logo.png | Adds archived logo image. |
| public/2025/assets/speakers/megan_peters.jpg | Adds archived speaker image. |
| public/2025/assets/speakers/katja_heuer.jpg | Adds archived speaker image. |
| package-lock.json | Lockfile updated (appears regenerated/modified). |
| .github/workflows/update-projects.yml | Updates GitHub Pages deploy configuration (keep_files). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| publish_dir: ./build | ||
| publish_branch: deployed | ||
| keep_files: true |
There was a problem hiding this comment.
Setting keep_files: true for peaceiris/actions-gh-pages will retain files on the deployed branch that are no longer present in ./build, which can leave stale/outdated assets deployed (especially with hashed filenames). Unless you have a specific need to preserve extra files on the branch, consider removing keep_files or adding an explicit cleanup strategy so the deployed site matches the current build output.
| keep_files: true |
| { | ||
| "short_name": "React App", | ||
| "name": "Create React App Sample", | ||
| "icons": [ |
There was a problem hiding this comment.
The archived manifest still uses Create React App defaults ("short_name": "React App", "name": "Create React App Sample"). If this archive is intended to be user-facing, consider updating these fields (and potentially theme/background colors) to reflect the BrainHack Vanderbilt 2025 archive branding.
| @@ -0,0 +1 @@ | |||
| <!doctype html><html lang="en"><head><script defer="defer" src="/2025/static/js/main.6c178bc1.js"></script><link href="/2025/static/css/main.58184435.css" rel="stylesheet"></head><head><meta charset="utf-8"/><link rel="icon" href="/2025/favicon.png"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="manifest" href="/2025/manifest.json"/><title>BrainHack Vanderbilt</title><meta name="description" content="BrainHack Vanderbilt Website"><body><div id="root"></div></body></head></html> No newline at end of file | |||
There was a problem hiding this comment.
/2025/favicon.png is referenced by this archive (<link rel="icon" href="/2025/favicon.png"/>) but there is no public/2025/favicon.png in the tree, so the favicon link will 404. Add the referenced favicon file under public/2025/ (and ensure it’s included in the archive) or update the HTML to point at an existing icon asset.
| "icons": [ | ||
| { | ||
| "src": "favicon.png", | ||
| "sizes": "64x64 32x32 24x24 16x16", | ||
| "type": "image/x-icon" | ||
| } |
There was a problem hiding this comment.
The manifest declares an icon at favicon.png, but there is no public/2025/favicon.png in the archive, so PWA/icon fetches will 404. Add the file at the declared path or update icons[].src to a file that actually exists within the 2025 archive assets.
| @@ -0,0 +1 @@ | |||
| <!doctype html><html lang="en"><head><script defer="defer" src="/2025/static/js/main.6c178bc1.js"></script><link href="/2025/static/css/main.58184435.css" rel="stylesheet"></head><head><meta charset="utf-8"/><link rel="icon" href="/2025/favicon.png"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="manifest" href="/2025/manifest.json"/><title>BrainHack Vanderbilt</title><meta name="description" content="BrainHack Vanderbilt Website"><body><div id="root"></div></body></head></html> No newline at end of file | |||
There was a problem hiding this comment.
index.html is not valid HTML: it contains two <head> elements and places <body> inside the second <head>, which can lead to inconsistent rendering and metadata/script loading across browsers. Rebuild/fix the archived HTML so it has a single <head> (meta/link/script tags) followed by a <body> and proper closing tags.
| <div className="content-wrapper"> | ||
| <h1 className="heading"> | ||
| Hi There!{" "} | ||
| Hello There!{" "} |
There was a problem hiding this comment.
This greeting text change appears unrelated to the PR description (which focuses on adding a 2025 static archive under public/). Consider moving this change to a separate PR or updating the PR description to reflect the additional UI change, to keep scope and review history clear.
|
projects don't show up neither in the archived nor in the main build. It might be due to the delay in building them ( I think David put an hourly check for build for this ). If there is a better way to do this i.e. triggered by some event to get build rather than building it every hour ... that would be superb. |
|
TLDR: So if we just publish the website as is, project cards for 2025 should resolve but we cant preview it on localhost. The if we save a snapshot of the open issues as a json file and add it to datautils, then it should resolve this issue and allow us to close the open project issues from 2025 without breaking the project cards. |
|
Hey! Pushed a fix for the local preview issue with project cards. Added a committed snapshot file |
Added a folder under Public with pre built static files of Archive version of Brainhack site from 2025