Skip to content

Trim back the website to remove any dated information#35

Merged
tclose merged 9 commits intobrainhackorg:mainfrom
tclose:trimmed-back
Sep 23, 2024
Merged

Trim back the website to remove any dated information#35
tclose merged 9 commits intobrainhackorg:mainfrom
tclose:trimmed-back

Conversation

@tclose
Copy link
Copy Markdown
Member

@tclose tclose commented Sep 12, 2024

  • updates the Gemfile so that the bundle can be served with Ruby 3
  • Reworked menu to move references to dated material to less prominent places
  • Added events for past and previous BrainHack Globals

@tclose tclose changed the title Trims back the website to remove any dated information Trim back the website to remove any dated information Sep 12, 2024
@tclose tclose marked this pull request as ready for review September 12, 2024 12:41
@jhlegarreta
Copy link
Copy Markdown
Contributor

Thanks for doing this @tclose. I'm finding it hard to review some parts, would it be possible:

  • To add a body to the commits so that they get some description?
  • To split commits into with different commits so that they contain only one relevant change, e.g. change the layout vs. add content? e.g. ef1f7b6
  • To know how does the new website look like?
  • To know what dated information was removed ef1f7b6? I've compared the removed lines and the added ones, and there seems to be no removal in that commit?
  • To know where was this information transferred to 4986c56, especially the links to the proceedings?

@tclose
Copy link
Copy Markdown
Member Author

tclose commented Sep 17, 2024

Ok, I have rebased the PR to clean it up a bit and split a couple of commits

  • To add a body to the commits so that they get some description?

Which commits need more description? Is it a bit easier to follow them now?

  • To split commits into with different commits so that they contain only one relevant change, e.g. change the layout vs. add content? e.g. ef1f7b6

I have split up c822bcd]

  • To know how does the new website look like?

Much the same, here is a screen shot of the rearranged home page (the style is unchanged)

Screen Shot 2024-09-13 at 9 45 44 am

Are you able to install the dev env to have a look at it interactively (i.e.install Ruby and then bundle install and bundle exec jekyll serve)?

  • To know what dated information was removed ef1f7b6? I've compared the removed lines and the added ones, and there seems to be no removal in that commit?

c822bcd: Moves the old posts into the ARCHIVE menu item

ec6f180: deletes dated proceedings and outcomes from the about page.

  • To know where was this information transferred to 4986c56, especially the links to the proceedings?

It is now under the ARCHIVE menu item

@tclose
Copy link
Copy Markdown
Member Author

tclose commented Sep 17, 2024

Do you know who the current board members are (if the board still exists in practice)?

@jhlegarreta
Copy link
Copy Markdown
Contributor

Is there a reason why the following commit uses ".markdown" instead of ".md" as the file extension?
1647942

I guess removing the projects in the Brainhack Outcomes section is reasonable as they are several years old, but the publications should be linked from somewhere IMO:
ec6f180

Which commits need more description?

If you click on each commit https://github.com/brainhackorg/brainhackorg.github.io/pull/35/commits you will see that none of them has a commit message body, only a subject, some being cut due to excessive line length, etc.

e.g. efdb42c does more than renaming a file. Adding a commit message gives ample space to provide the necessary details about the change.

Is it a bit easier to follow them now?

It is.

Much the same, here is a screen shot of the rearranged home page (the style is unchanged)

OK.

Are you able to install the dev env to have a look at it interactively (i.e.install Ruby and then bundle install and bundle exec jekyll serve)?

Have not tried Tom, sorry. I do not have the bandwidth now.

Do you know who the current board members are (if the board still exists in practice)?

I don't Tom, sorry. I have not been active lately in the Brainhacks.

@tclose
Copy link
Copy Markdown
Member Author

tclose commented Sep 17, 2024

Is there a reason why the following commit uses ".markdown" instead of ".md" as the file extension? 1647942

I was just following the style of the other posts

I guess removing the projects in the Brainhack Outcomes section is reasonable as they are several years old, but the publications should be linked from somewhere IMO: ec6f180

They are still accessible from the ARCHIVE menu on the home page. I can add them back in but having the last one showing up from 5 years ago on the About page gives the impression the org is dead IMO.

Which commits need more description?

If you click on each commit https://github.com/brainhackorg/brainhackorg.github.io/pull/35/commits you will see that none of them has a commit message body, only a subject, some being cut due to excessive line length, etc.

I have never written a commit body in 15 years, is it necessary when you have the diffs?

e.g. efdb42c does more than renaming a file. Adding a commit message gives ample space to provide the necessary details about the change.

It renames the file, the corresponding title of the page, and adds a link to the mattermost channel. Do I have to spell out every minor change? Isn't the final state the most important?

Are you able to install the dev env to have a look at it interactively (i.e.install Ruby and then bundle install and bundle exec jekyll serve)?

Have not tried Tom, sorry. I do not have the bandwidth now.

I also have very little bandwidth. I'm just trying to get this fixed as it looked like it needed doing.

Do you know who the current board members are (if the board still exists in practice)?

I don't Tom, sorry. I have not been active lately in the Brainhacks.

I'm getting the impression that no one really has.

@crnolan
Copy link
Copy Markdown
Collaborator

crnolan commented Sep 20, 2024

  • Brainhack Global 2024 banner on front page has "Hybird" rather than "Hybrid"
  • Promote a project or event: "Mattermost channel" is a bit orphaned there with no explanation - it should be a bullet point and possibly a little explanation "Many Brainhack events choose to communicate via the Brianhack Mattermost server; join here and create a channel for your event."

@crnolan
Copy link
Copy Markdown
Collaborator

crnolan commented Sep 20, 2024

Perhaps the mattermost server could be linked on the About page as well, but can easily be done later.

@tclose
Copy link
Copy Markdown
Member Author

tclose commented Sep 23, 2024

I believe these issues have been addressed now so will merge the changes in

@tclose tclose merged commit 7e25f7d into brainhackorg:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants