Update connection logic to prevent errors#39
Closed
XerxesDGreat wants to merge 1 commit intomasterfrom
unknown repository
Closed
Update connection logic to prevent errors#39XerxesDGreat wants to merge 1 commit intomasterfrom unknown repository
XerxesDGreat wants to merge 1 commit intomasterfrom
unknown repository
Conversation
Use ImmutableSet and Iterators to prevent ConcurrentModificationExceptions. Introduce a ConnectErrorHandler so users of this library can handle any errors encountered during connection instead of having the errors just get swallowed in a different thread which causes the connection timer to fail and eventually lose servers during autoscaling.
Author
|
sorry, didn't mean to post this here yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ImmutableSet and Iterators to prevent ConcurrentModificationExceptions.
Introduce a ConnectErrorHandler so users of this library can handle any
errors encountered during connection instead of having the errors just
get swallowed in a different thread which causes the connection timer to
fail and eventually lose servers during autoscaling.