Skip to content

Fix "amsgrad" is used before being defined when initializing the AdamW optimizer #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaoming0625 merged 3 commits into from
Mar 29, 2024
Merged

Fix "amsgrad" is used before being defined when initializing the AdamW optimizer #660

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21b30ff
Fix delayvar not correct in concat mode
CloudyDory Feb 22, 2024
851d01f
Merge branch 'brainpy:master' into master
CloudyDory Mar 29, 2024
e5b66ab
Update AdamW in optimizer.py
CloudyDory Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion brainpy/_src/optimizers/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,7 @@ def __init__(
amsgrad: bool = False,
name: Optional[str] = None,
):
self.amsgrad = amsgrad
super(AdamW, self).__init__(lr=lr,
train_vars=train_vars,
weight_decay=weight_decay,
Expand All @@ -919,7 +920,6 @@ def __init__(
self.beta2 = beta2
self.eps = eps
self.weight_decay = weight_decay
self.amsgrad = amsgrad

def __repr__(self):
return (f"{self.__class__.__name__}(lr={self.lr}, "
Expand Down