Feature/ota server#75
Merged
Merged
Conversation
- Related to issue brainstorm#24 Firmware update via SFTP **Warning:** Using unmerged sunset-ota package. This is not a sunset feature until it is approved. Reusing code from the previously closed PR55 Task: Firmware update via SFTP. It fills the gaps that previous PR had prepared: - Feature/workspaces (PR57), - Feature/ota placeholder (PR58), - New feature: ota TLV and ota-packer utility (PR59)
- Related to issue brainstorm#24 Firmware update via SFTP **Warning:** Using unmerged sunset-ota package. This is not a sunset feature until it is approved. Adding ota readme and hil test. these files have been obtained from the closed PR55 Task: Firmware update via SFTP
Related to Testing brainstorm#37: - Checking the running partition offset once the ota has been applied - Function refactoring - Avoiding temp files for expect script and instead exporting ENV_VARS - Adding TODO: Repace this heavy scripts with rexpect from crates.io? Documentation in /ota/README.md updated and including a section on testing
Collaborator
Author
|
The CI does not pass. I have done it again: Apologies. I will fix the warnings next to get the CI passing. This has to do with the feature flag |
When sftp-ota is not included: - serve.rs::SessionType::Sftp() variant is not defined - serve.rs::connection_loop(): events matching subsystem sftp will send to the client a fail - serve.rs::handle_ssh_client() won't have a matching case for sftp-ota I believe that commenting out all this code is the most efficient way to act in absence of sftp-ota and causes no more trouble with warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing Firmware update via SFTP feature
This is about #24 mostly, but also touches testing (#37). This PR fills the gaps in the placeholders created previously in PR57 PR58 and PR59. The code comes from the too detailed and closed PR55.
What it does?
On builds with the feature sftp-ota, it will populate an sftp server that accept binaries bundled with some metadata by ota-packer. After that saves the application binary into the next ota slot and at the same time computes a checksum and restart, load and validate the new application.
As an extra I have included and improved
ota/test-hil-e2e-esp32c6.shwhich is the first hardware in the loop end to end test in SSH-Stamp that now also checks the offset of the running application after applying the OTA.More information can be found in
/ota/README.mdand in the rustdocs in the new package.