Remove braintrust_core dep#146
Merged
Manu Goyal (manugoyal) merged 1 commit intomainfrom Sep 8, 2025
Merged
Conversation
`autoevals` is the only package that depends on it, so we can just move the class definitions into the autoevals package.
Braintrust eval reportAutoevals (manu/remove-braintrust-core-dep-1757296009)
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+36
to
+39
| print( | ||
| "The error field is deprecated, as errors are now propagated to the caller. The field will be removed in a future version of the library", | ||
| sys.stderr, | ||
| ) |
There was a problem hiding this comment.
The print function is using sys.stderr as a positional argument rather than as the file parameter. This will cause the string sys.stderr to be printed as part of the message instead of directing the output to the error stream.
The correct syntax should be:
print(
"The error field is deprecated, as errors are now propagated to the caller. The field will be removed in a future version of the library",
file=sys.stderr
)
Suggested change
| print( | |
| "The error field is deprecated, as errors are now propagated to the caller. The field will be removed in a future version of the library", | |
| sys.stderr, | |
| ) | |
| print( | |
| "The error field is deprecated, as errors are now propagated to the caller. The field will be removed in a future version of the library", | |
| file=sys.stderr, | |
| ) | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Manu Goyal (manugoyal)
added a commit
to braintrustdata/braintrust-sdk-javascript
that referenced
this pull request
Sep 8, 2025
Ankur Goyal (ankrgyl)
approved these changes
Sep 8, 2025
Manu Goyal (manugoyal)
added a commit
to braintrustdata/braintrust-sdk-javascript
that referenced
this pull request
Sep 8, 2025
Braintrust eval report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autoevalsis the only package that depends on it, so we can just move the class definitions into the autoevals package.