[OAI] Support braintrust >=0.13 wrapping (fix Python CI)#193
Draft
Kenny Wong (wong-codaio) wants to merge 1 commit into
Draft
[OAI] Support braintrust >=0.13 wrapping (fix Python CI)#193Kenny Wong (wong-codaio) wants to merge 1 commit into
Kenny Wong (wong-codaio) wants to merge 1 commit into
Conversation
2 tasks
braintrust 0.13 removed the wrapper classes and changed wrap_openai to patch resource methods in place (wrapt FunctionWrapper) instead of returning a NamedWrapper proxy. The isinstance(client, NamedWrapper) check no longer detected wrapping (is_wrapped wrongly False, so scorer spans lost their purpose), and test_oai.py imported now-removed classes, aborting collection. Detect wrapping in a version-agnostic way: NamedWrapper for <0.13, wrapt wrapper type on create() for >=0.13. Note >=0.13 only instruments the v1 SDK, so v0 clients are no longer traced; tests updated to match.
da14027 to
7da7460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[OAI] Support braintrust >=0.13 wrapping (fix Python CI)
wrap_openaito patch methods in place (wrapt) instead of returning aNamedWrapper, and dropped the*Wrapperclasses — breakingis_wrappeddetection andtest_oai.py's imports (collection abort → red Python CI on every PR).NamedWrapper(<0.13) or wrapt wrapper oncreate()(>=0.13).PTAL:
FYI:
Test plan
pytest py/autoevals/→ 68 passed on braintrust 0.23 (was: collection ImportError)check_braintrust_wrapping.py(run it yourself)Other Notes