fix: wire BraintrustConfig.sslContext into the API HTTP client#94
Merged
Andrew Kent (realark) merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
BraintrustConfig already accepted a custom SSLContext via its builder and applied it to the OTLP span exporter, but createDefaultHttpClient ignored it — leaving BraintrustApiClient always using the JVM default trust store. Customers with custom CAs or internal PKI hit certificate validation errors with no way to override them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Andrew Kent (realark)
approved these changes
Apr 28, 2026
Collaborator
|
thanks for submitting this Doug Guthrie (@dpguthrie) ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BraintrustConfig already accepted a custom SSLContext via its builder and applied it to the OTLP span exporter, but createDefaultHttpClient ignored it — leaving BraintrustApiClient always using the JVM default trust store. Customers with custom CAs or internal PKI hit certificate validation errors with no way to override them.
This came from customer feedback: