feat: attach saved parameters to experiments#1550
Merged
Joshua Wootonn (joshuawootonn) merged 6 commits intomainfrom Mar 13, 2026
Merged
feat: attach saved parameters to experiments#1550Joshua Wootonn (joshuawootonn) merged 6 commits intomainfrom
Joshua Wootonn (joshuawootonn) merged 6 commits intomainfrom
Conversation
| ) { | ||
| const { data, baseExperiment: defaultBaseExperiment } = evaluatorData; | ||
| const parameters = await getExperimentParametersRef(evaluator.parameters); | ||
| // NOTE: This code is duplicated with initExperiment in js/src/framework.ts. |
Contributor
Author
There was a problem hiding this comment.
You will notice that getExperimentParametersRef is duplicated, and this comment is the reason why I'm just following the pattern of existing code.
Joshua Wootonn (joshuawootonn)
force-pushed
the
feat/experiment-parameters-backlinks-sdk
branch
from
a1383fc to
c5d91a1
Compare
Contributor
Author
|
The API surface is technically expanding here. I added a new optional key |
Joshua Wootonn (joshuawootonn)
requested review from
Abhijeet Prasad (AbhiPrasad),
Caitlin Pinn (cpinn) and
Luca Forstner (lforst)
Luca Forstner (lforst)
approved these changes
Mar 13, 2026
Joshua Wootonn (joshuawootonn)
deleted the
feat/experiment-parameters-backlinks-sdk
branch
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the JavaScript SDK to save parameters information so that I can display in the UI what
Parameterswere associated with each experiment.Demo
CleanShot.2026-03-12.at.14.01.13.mp4
Related PRs