fix: flush pass in evaluator state if it exists#1581
Merged
Abhijeet Prasad (AbhiPrasad) merged 3 commits intomainfrom Mar 17, 2026
Merged
fix: flush pass in evaluator state if it exists#1581Abhijeet Prasad (AbhiPrasad) merged 3 commits intomainfrom
Abhijeet Prasad (AbhiPrasad) merged 3 commits intomainfrom
Conversation
Member
|
yeah this looks fine to me! Let me add a test and we can merge it in. Gonna rebase the PR to include the latest changes from |
Abhijeet Prasad (AbhiPrasad)
changed the title
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 17, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if code change this is correct, but in the playground code flow we pass in a parent and state in the param. I'm assuming that if we call flush with a custom parent we would want to flush to a state from the params if it was provided. Please advise, thanks