ref(e2e): move nextjs-instrumentation from smoke tests to e2e scenarios#1654
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intomainfrom Mar 25, 2026
Conversation
Migrate the nextjs-instrumentation scenario from js/smoke/scenarios/ to e2e/scenarios/ to use the standard e2e test harness with mock server and snapshot-based assertions. This replaces the manual smoke test approach (Makefile + dev server polling) with proper e2e scenario infrastructure. Key changes: - Add scenario.ts and scenario.test.ts for e2e framework integration - Add snapshot files for otel spans, request flow, route responses, and span events - Add API route handlers for edge and node runtime smoke tests - Add runtime-check utility library - Remove old Makefile, mise.toml, README, and manual test runner - Update js/smoke/README.md to remove nextjs-instrumentation references - Clean up pnpm-lock.yaml (remove next@16 and related dependencies)
Luca Forstner (lforst)
approved these changes
Mar 25, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-refactor-move-nextjs-instrumentation-to-e2e
branch
Luca Forstner (lforst)
added a commit
that referenced
this pull request
Mar 27, 2026
Forgot this as part of #1654 Co-authored-by: Luca Forstner <luca.forstner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the nextjs-instrumentation scenario from js/smoke/scenarios/ to e2e/scenarios/ to use the standard e2e test harness with mock server and snapshot-based assertions. This replaces the manual smoke test approach (Makefile + dev server polling) with proper e2e scenario infrastructure.
Key changes: